[Quality] Unresolved critical PR comment was merged into main and should have been addressed
Resolved 💬 2 comments Opened Mar 25, 2026 by morozow Closed Mar 25, 2026
💡 Likely answer: A maintainer (etraut-openai, contributor)
responded on this thread — see the highlighted reply below.
A mutable 'config' argument breaks platform consistency. It is better to keep data changes at a single, direct entry point. At the same time, binding this function directly to 'Config' type limits future extensibility. A trait-based generic would preserve the same flow while allowing extended mutable config types later.
_Originally posted by @morozow in #15722_
2 Comments
If you'd like to file a bug report, please fill out the information request in the bug template including a bug description, repro steps, etc.
@etraut-openai Bug reports and implementation practices are different sides of reporting. A bug means it does not work, while a failed implementation practice means a merged PR introduces bad practices that will lead to long-term maintenance problems later, even if it works well now. These are totally different sides of my two cents.