codex_mcp_interface.md approval section describes stale wire shape

Open 💬 1 comment Opened Jun 1, 2026 by bar-d

What happened?

codex-rs/docs/codex_mcp_interface.md documents approval requests as custom JSON-RPC methods:

applyPatchApproval { conversationId, callId, fileChanges, reason?, grantRoot? }
execCommandApproval { conversationId, callId, approvalId?, command, cwd, reason? }

and says clients should reply with:

{ "decision": "allow" | "deny" }

The current MCP server implementation appears to send elicitation/create requests for both exec and patch approvals instead. The MCP server tests also assert elicitation/create and respond with review-decision values, not the documented custom approval methods / allow or deny shape.

Expected behavior

The MCP interface documentation should describe the current approval wire shape, or clearly mark the listed custom approval methods as obsolete if they are no longer used.

Additional context

I searched open issues and PRs for terms including codex_mcp_interface, applyPatchApproval, execCommandApproval, and elicitation/create. I did not find an existing open item for this approval-section-specific doc drift. This is separate from #25518, which covers the broader app-server-vs-mcp-server RPC mismatch in the same document.

View original on GitHub ↗

This issue has 1 comment on GitHub. Read the full discussion on GitHub ↗