Prompt input don't look good on MacOS transparent terminal

Similar to what I see here: #4809

We've made some improvements in this area since this bug was filed, so I'm going to close.

You may need to make adjustments in your terminal appearance settings.

We've made some improvements in this area since this bug was filed, so I'm going to close. You may need to make adjustments in your terminal appearance settings.

This is still an issue in 0.93. It's unrelated to my terminal settings, since it's not present when downgrading to <0.44.

@owenthewizard, we have definitely changed the styling since 0.44. That was by design. If I remember correctly, we're using an italic style for this text. Your terminal settings will dictate how this is displayed. It looks fine on most terminal emulators using their default settings. Since there are so many variants of terminal emulators across all supported platforms, it's difficult to make them all work by default, and impossible to make them look good across all possible settings. Out of curiosity, which terminal emulator are you using, and are you using any custom settings or themes?

@owenthewizard, we have definitely changed the styling since 0.44. That was by design. If I remember correctly, we're using an italic style for this text. Your terminal settings will dictate how this is displayed. It looks fine on most terminal emulators using their default settings. Since there are so many variants of terminal emulators across all supported platforms, it's difficult to make them all work by default, and impossible to make them look good across all possible settings. Out of curiosity, which terminal emulator are you using, and are you using any custom settings or themes?

Respectfully, I'm not sure you understood the report:

1. It's still an issue in 0.91+.
2. The regression occurred in either 0.43 or 0.44, and is not present <= 0.42.
3. Font rendering is not an issue; it's the background color.
4. I can reproduce in both kitty and foot when using a transparent background.
5. I'm using Wayland.

If I had to guess, <= 0.42 the background was not specifically set (I assume in ratatui), and it was later changed to be set explicitly. It should be pretty simple to reproduce this, many terminal emulators support transparency. Maybe @dkvarda can let us know what terminal they're using for an additional DP.

The placeholder text for the input box using a "dim" ratatui style. Here is the code. A "dim" style makes sense for placeholder text, and it renders well in most terminals. I don't think we're setting a background color explicitly here. It's possible that ratatui (the library used in Codex) does set the background color for the "dim" style.

@joshka-oai, perhaps you have some thoughts here?

Thanks for the hint, I'll git bisect when I have some time and see if I can find anything interesting.

43b63ccae89cf911c1d3fecc4577a98b898d6048

It was added in #4240 as a "feature"...

Here's my "fix"

diff --git a/codex-rs/tui/src/bottom_pane/chat_composer.rs b/codex-rs/tui/src/bottom_pane/chat_composer.rs
index b3c1eea6d..60b821d86 100644
--- a/codex-rs/tui/src/bottom_pane/chat_composer.rs
+++ b/codex-rs/tui/src/bottom_pane/chat_composer.rs
@@ -1268,11 +1268,10 @@ impl WidgetRef for ChatComposer {
                 );
             }
         }
-        let style = user_message_style(terminal_palette::default_bg());
         let mut block_rect = composer_rect;
         block_rect.y = composer_rect.y.saturating_sub(1);
         block_rect.height = composer_rect.height.saturating_add(1);
-        Block::default().style(style).render_ref(block_rect, buf);
+        Block::default().render_ref(block_rect, buf);
         buf.set_span(
             composer_rect.x,
             composer_rect.y,

But it seems like this is a feature, not a bug...

Yeah, we actively wanted to render this with a style that was similar to the user's bg color, but not as dark (or light) so that this appears to pop out of the space. That necessitates rendering actual colors for the style, rather than just the bg/fg colors

We plan to support themes sometime soon. I'll make a mental note to consider transparency as a config option if it makes sense there.

Yeah, we actively wanted to render this with a style that was similar to the user's bg color, but not as dark (or light) so that this appears to pop out of the space. That necessitates rendering actual colors for the style, rather than just the bg/fg colors We plan to support themes sometime soon. I'll make a mental note to consider transparency as a config option if it makes sense there.

Cool, would be nice to see it as a config option in the future.