Make `/review` configurable to specify number of issues
What feature would you like to see?
Not a feature request (unless there's room to improve)
/review is just amazing. The way it's been implemented to work in a separate isolated context (with its own window) is praiseworthy; and the way it performs an isolated review is just how it should be. Thank you!
The way it walks through the code, scrutinizing every line, every character modified, every input combination of every function is amazing. Sure, it rarely flags non-issues but only rarely.
Excellent work on this guys, please don't take this feature away. I'd say this one feature alone justifies the cost for going Pro.
If I could change one thing? That is that /review seems to currently only return a single issue (most of the times a P0 and it'll abruptly stop) - I wish there was at least an option to allow /review to continue hunting for a few more issues and list them all in one go. A single review can take 5 - 15minutes at times, depending upon the complexity of code, but one has to run these back to back when a _fix_ in between was just tweaking one or two lines of code, only to discover from a second review that there's one more place to fix.
Additional information
_No response_
15 Comments
Potential duplicates detected. Please review them and close your issue if it is a duplicate.
Powered by Codex Action
I agree with everything that has been said here!
In addition to being able to submit multiple suggestions, it would be great to be able to launch a review in non-interactive mode, such as
codex review --branch my-feature --base develop, or something like that.Thanks for the positive feedback! We're glad you like the feature.
And thanks also for the suggestions. I'm going to change the title of the issue to reflect the enhancement request.
When does this land? It will greatly improve using codex as reviewer in github integration
When can we expect this landing? This really makes us think to getting another agent x github integration if there is no timeline
+1, useless without this.
@etraut-openai can you put attention to this please?
+1, I keep fixing 1 or 2 and then have it run another review.
This might help some people. What I do is I paste this prompt into my locally running codex agent. Note: it's important that it have GitHub CLI access to your repo. If you're ok with this level of trust, then ship it. It has worked well for me at least. I go work on other things, and eventually it's done and I can review what it did. YMMV 🤷♂️
TL;DR - it runs a loop where it polls for additional review comments and then fixes them until there are no more comments.
@etraut-openai any update on when we can expect this to land? It would be nice to have this configurable code review option.
Yes, running every time to find new P1s is insane. Especially when the first attempt displays P1 and P2 (2 findings), but the second attempt does it again. Why not use P1 + P1 the first time?
Why we can't just get it to find ALL issues in the single run?
1 - 2 findings at a time will never be useful to any of my processes. in the real world, who does a Pr review, finds several P1 findings, and only reports 1-2 of them, saving the rest for after the author fixes one issue? It's problematic for many reasons. I've been forced to remove codex from my pipeline and rely on other tools.
+1
I’ve been stuck in a push/review loop for hours. So frustrating 😭
Does anybody how under what conditions Codex limits the findings it returns? I'm worried about this issue, but I can't reproduce it.