Update prompt reappears after selecting "Update now" due to missing dismiss_version call
What version of Codex is running?
0.72.0
What subscription do you have?
PLus
Which model were you using?
N/A - this is a CLI update prompt bug, not model-related
What platform is your computer?
Linux 6.14.0-36-generic x86_64
What issue are you seeing?
When selecting "Update now" from the update prompt, the prompt reappears on the next launch even though the update completed successfully.
This happens because dismiss_version() is only called when user selects "Skip until next version", but not when they select "Update now".
Location: codex-rs/tui2/src/update_prompt.rs lines 71-75
What steps can reproduce the bug?
- Have an older version of Codex installed
- Launch Codex - see update prompt
- Select "Update now"
- Update completes successfully
- Relaunch Codex
- Update prompt appears again for the same version
Root cause in code: - "Skip until next version" calls updates::dismiss_version()` (line 78)
- "Update now" does NOT call
dismiss_version()(line 72-74)
Fix: Add dismiss_version() call before returning RunUpdate:
``rust
Some(UpdateSelection::UpdateNow) => {
if let Err(err) = updates::dismiss_version(config, screen.latest_version()).await {
tracing::error!("Failed to persist update dismissal: {err}");
}
tui.terminal.clear()?;
Ok(UpdatePromptOutcome::RunUpdate(update_action))
}
What is the expected behavior?
After selecting "Update now" and the update completes, the update prompt should not reappear for that version on the next launch.
Additional information
Same fix needed in both:
- codex-rs/tui/src/update_prompt.rs
- codex-rs/tui2/src/update_prompt.rs
Happy to submit a PR if this approach is accepted.
This issue has 1 comment on GitHub. Read the full discussion on GitHub ↗